Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Use "url" variable in the example #2015

Merged
merged 1 commit into from Jun 6, 2016
Merged

Conversation

@lopuhin
Copy link
Member

@lopuhin lopuhin commented May 27, 2016

Instead of hardcoded http://www.example.com, as noticed by Andrés Pérez-Albela H.: without it url variable is unused and only one request will make it past dupefilter.

Instead of hardcoded http://www.example.com: without it url variable is unused and only one request will make it past dupefilter.
@kmike kmike changed the title Use "url" variable in the example [MRG+1] Use "url" variable in the example May 27, 2016
@redapple redapple merged commit f929853 into scrapy:master Jun 6, 2016
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple
Copy link
Contributor

@redapple redapple commented Jun 6, 2016

Thanks @lopuhin

redapple added a commit that referenced this pull request Jun 8, 2016
[backport][1.1] Use "url" variable in the example (PR #2015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.