Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Encourage complete titles in pull requests #2026

Merged
merged 1 commit into from Jul 8, 2016

Conversation

@Digenis
Copy link
Member

@Digenis Digenis commented Jun 4, 2016

Linking to an issue when creating a PR is useful
but authors sometimes replace the whole subject with "Fix+tests for #000"
which makes it hard to skim through the issue tracker or its feed
especially when the description is missing from the PR itself.
This is even more important for commit messages.

With this pr I want to open the discussion;
I'm not fully convinced that this is the role of the documentation
but I wrote it there as a start.

@@ -100,6 +100,11 @@ starting point is to send a pull request on GitHub. It can be simple enough to
illustrate your idea, and leave documentation/tests for later, after the idea
has been validated and proven useful. Alternatively, you can send an email to
`scrapy-users`_ to discuss your idea first.
When writting GitHub pull requests, try to keep titles short but descriptive.

This comment has been minimized.

@nyov

nyov Jul 2, 2016
Contributor

s/writting/writing/

@Digenis Digenis force-pushed the Digenis:contributing-full_subjects branch from 974f951 to 2a92ffb Jul 5, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 5, 2016

Current coverage is 83.33%

Merging #2026 into master will not change coverage

Powered by Codecov. Last updated by 80c296e...2a92ffb

@eliasdorneles eliasdorneles changed the title Encourage complete titles in pull requests [MRG+1] Encourage complete titles in pull requests Jul 5, 2016
@kmike kmike merged commit 5f261cf into scrapy:master Jul 8, 2016
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 80c296e...2a92ffb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
redapple added a commit that referenced this pull request Jul 8, 2016
[backport][1.1] Encourage descriptive PR titles (PR #2026)
@Digenis Digenis deleted the Digenis:contributing-full_subjects branch Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.