[MRG] Do not fail on canonicalizing URLs with wrong netlocs #2038
Conversation
Current coverage is 83.34%
|
redapple
changed the title
redapple
added a commit
that referenced
this pull request
Jul 8, 2016
[backport][1.1] Do not fail on canonicalizing URLs with wrong netlocs (PR #2038)
|
This PR fixes |
|
Good point. Have you spotted other places where this could break still? |
|
It seems your PR should fix the issue, there are no other uses of idna encoding in w3lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #2010
Not quite sure what to do with non-ASCII chars in netlocs that do not convert well with IDNA rules.
Left the netloc as is for now.