Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] [docs] add note about windows + python3 #2060

Merged
merged 3 commits into from Jul 5, 2016

Conversation

@pawelmhm
Copy link
Contributor

@pawelmhm pawelmhm commented Jun 17, 2016

#2056 seems like common issue (e.g. user here: http://stackoverflow.com/questions/36857638/can-i-run-scrapy-on-windows-with-python-3/37418422) , should we also update installation guide with note about Python 3? Currently it does not say anything about Python 3 but people assume 3 should be supported.

@codecov-io
Copy link

@codecov-io codecov-io commented Jun 17, 2016

Current coverage is 83.32%

Merging #2060 into master will decrease coverage by 0.01%

Powered by Codecov. Last updated by 80c296e...b67440d

@redapple
Copy link
Contributor

@redapple redapple commented Jun 17, 2016

thanks @pawelmhm ,
yes, I think we need to update installation guide and also update the FAQ entry on Python 3. we never know on which page users land from a Google search

@pawelmhm
Copy link
Contributor Author

@pawelmhm pawelmhm commented Jun 20, 2016

yes, I think we need to update installation guide and also update the FAQ entry on Python 3. we never know on which page users land from a Google search

updated

@@ -71,7 +71,7 @@ What Python versions does Scrapy support?

Scrapy is supported under Python 2.7 and Python 3.3+.
Python 2.6 support was dropped starting at Scrapy 0.20.
Python 3 support was added in Scrapy 1.1.
Python 3 support was added in Scrapy 1.1. Python 3 is not yet supported on Windows.

This comment has been minimized.

@redapple

redapple Jun 20, 2016
Contributor

Can I suggest using a note or warning for this (or at least making it bold)?

This comment has been minimized.

@pawelmhm

pawelmhm Jul 4, 2016
Author Contributor

I changed this to "note"

@@ -85,6 +85,10 @@ Windows

pip install Scrapy

.. note::
Python 3 is not supported on Windows. Installation of Scrapy on Windows

This comment has been minimized.

@redapple

redapple Jun 20, 2016
Contributor

It's more about Twisted on Windows under Python 3

This comment has been minimized.

@pawelmhm

pawelmhm Jul 4, 2016
Author Contributor

yeah I updated this part, I see there is ticket for this in Twister repo here: https://twistedmatrix.com/trac/ticket/8018

@redapple
Copy link
Contributor

@redapple redapple commented Jun 20, 2016

Thanks @pawelmhm , added a few comments.

@redapple redapple changed the title [docs] add note about windows + python3 [MRG+1] [docs] add note about windows + python3 Jul 5, 2016
@redapple
Copy link
Contributor

@redapple redapple commented Jul 5, 2016

Thanks @pawelmhm !

@eliasdorneles eliasdorneles merged commit 441df4c into scrapy:master Jul 5, 2016
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 80c296e...b67440d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
redapple added a commit that referenced this pull request Jul 8, 2016
[backport][1.1] [docs] Add note about Windows + Python3 (PR #2060)
@Namsto
Copy link

@Namsto Namsto commented Sep 22, 2016

Do we will support "Scrapy + Python 3 + Windows" in later release?

@redapple
Copy link
Contributor

@redapple redapple commented Sep 22, 2016

Twisted has not announced Python 3 + Windows support yet, so Scrapy cannot support Python 3 on Windows yet.
See their release notes for Twisted 16.4

35+ more modules ported to Python 3, and many many cleanups on the way to Python 3 on Windows support.

Maybe with Twisted 16.5 or 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants