Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] TST pin pytest-cov to 2.2.1; upgrade pytest #2095

Merged
merged 1 commit into from Jul 6, 2016
Merged

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jul 6, 2016

Scrapy testing suite is failing now. I've tried to downgrage/upgrade several dependencies; this looks related to pytest-cov 2.3.0 release. pytest is upgraded just in case; just upgrading pytest didn't help.

@kmike
Copy link
Member Author

@kmike kmike commented Jul 6, 2016

Locally several tests fail for me with mysterious errors:

self = <tests.test_commands.ParseCommandTest testMethod=test_pipelines>
pp = <scrapy.utils.testproc.TestProcessProtocol instance at 0x104f15998>
cmd = ['/Users/kmike/svn/scrapy/.tox/py27/bin/python2.7', '-m', 'scrapy.cmdline', 'parse', '--spider', 'parse_spider', ...], check_code = True

    def _process_finished(self, pp, cmd, check_code):
        if pp.exitcode and check_code:
            msg = "process %s exit with code %d" % (cmd, pp.exitcode)
            msg += "\n>>> stdout <<<\n%s" % pp.out
            msg += "\n"
            msg += "\n>>> stderr <<<\n%s" % pp.err
>           raise RuntimeError(msg)
E           RuntimeError: process ['/Users/kmike/svn/scrapy/.tox/py27/bin/python2.7', '-m', 'scrapy.cmdline', 'parse', '--spider', 'parse_spider', '--pipelines', '-c', 'parse', 'http://localhost:50521/html'] exit with code 1
E           >>> stdout <<<
E           
E           
E           >>> stderr <<<
E           /Users/kmike/svn/scrapy/.tox/py27/bin/python2.7: No module named scrapy

but they pass when executed without the rest of testing suite. This PR haven't addressed it.

@codecov-io
Copy link

@codecov-io codecov-io commented Jul 6, 2016

Current coverage is 83.33%

Merging #2095 into master will not change coverage

Powered by Codecov. Last updated by 441df4c...4273734

@redapple
Copy link
Contributor

@redapple redapple commented Jul 6, 2016

+1 @kmike , I've also forced pytest-cov<2.3 locally and got rid of Coverage.py warning: No data was collected. message I was seeing

@redapple redapple changed the title TST pin pytest-cov to 2.2.1; upgrade pytest [MRG+1] TST pin pytest-cov to 2.2.1; upgrade pytest Jul 6, 2016
@kmike
Copy link
Member Author

@kmike kmike commented Jul 6, 2016

@redapple can we merge it?

@kmike kmike merged commit 8ec6c22 into master Jul 6, 2016
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 441df4c...4273734
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike
Copy link
Member Author

@kmike kmike commented Jul 6, 2016

hehe you're faster :)

@kmike kmike deleted the testing-deps branch Jul 6, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jul 6, 2016

👍

redapple added a commit that referenced this pull request Jul 8, 2016
[backport][1.1] TST pin pytest-cov to 2.2.1; upgrade pytest (PR #2095)
@redapple redapple added this to the v1.1.1 milestone Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants