Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Fix small grammar issue in practices.rst (Supersedes #2119) #2120

Merged
merged 1 commit into from Jul 12, 2016
Merged

(docs) Fix small grammar issue in practices.rst (Supersedes #2119) #2120

merged 1 commit into from Jul 12, 2016

Conversation

@kas
Copy link
Contributor

@kas kas commented Jul 12, 2016 •
edited

Hello,

As I was reading the (current 😂) docs I noticed a small grammar error. I've fixed it in this pull request

I've made this PR target the master branch instead of the 1.1 branch as requested
@kas
Update practices.rst
Loading status checks…
2489f84
@kas kas mentioned this pull request Jul 12, 2016
Closed
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 12, 2016

Current coverage is 83.37%

Merging #2120 into master will not change coverage

Powered by Codecov. Last updated by c3109da...2489f84
@eliasdorneles eliasdorneles merged commit 3b59155 into scrapy:master Jul 12, 2016
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing c3109da...2489f84
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jul 12, 2016

Thanks @kas ! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kas @codecov-io @eliasdorneles