Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Updated architecture graph for organization/clarity #2165

Merged
merged 2 commits into from Aug 6, 2016

Conversation

@loreguerra
Copy link
Contributor

@loreguerra loreguerra commented Aug 4, 2016

Found the first graph hard to read when first learning about Scrapy architecture.

Open to edits!!

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 4, 2016

Current coverage is 83.45% (diff: 100%)

Merging #2165 into master will not change coverage

Powered by Codecov. Last update 27d4cea...7d43287

@robsonpeixoto
Copy link

@robsonpeixoto robsonpeixoto commented Aug 4, 2016

IMHO 100% better 👏

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Aug 4, 2016

Wow, that's really neat, thank you! 👍

However, the numbers aren't quite matching the text now.
What is easier, to update the text or the graphic? :)

@loreguerra
Copy link
Contributor Author

@loreguerra loreguerra commented Aug 4, 2016

I figured I'd see what you all thought of that. The text smashes a few processes together.

Let me group the steps by text number (to avoid changing text) and organize steps by color.

I'll get back to you.

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Aug 4, 2016

Yeah, the text is mixing up some process, feel free to break it down!

Thank you so much for working in this, this is awesome!

I never grasped that old graphic, but this one I can actually follow! 😆

@loreguerra
Copy link
Contributor Author

@loreguerra loreguerra commented Aug 4, 2016

Great! I wasn't sure if it was just me! I'll work on it.

@loreguerra
Copy link
Contributor Author

@loreguerra loreguerra commented Aug 4, 2016

Edits made. Text should align with graphic now.

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Aug 4, 2016

Looks great, thank you very much @loreguerra !

@eliasdorneles eliasdorneles changed the title Updated architecture graph for organization/clarity [MRG+1] Updated architecture graph for organization/clarity Aug 4, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Aug 4, 2016

@loreguerra btw, could you include the vector file too?
Just in case we need to update it someday. =)

@loreguerra
Copy link
Contributor Author

@loreguerra loreguerra commented Aug 4, 2016

Sure thing. Attached.

scrapy.ai.zip

@kmike
Copy link
Member

@kmike kmike commented Aug 6, 2016

Awesome, thanks @loreguerra!

@kmike kmike merged commit fa78849 into scrapy:master Aug 6, 2016
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants