Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Correct documentation about Response parameters #2197

merged 2 commits into from Aug 29, 2016


Copy link

@thomdixon thomdixon commented Aug 24, 2016

This fixes issue #2196

thomdixon added 2 commits Aug 24, 2016
This fixes issue #2196
Copy link

@codecov-io codecov-io commented Aug 24, 2016

Current coverage is 83.40% (diff: 100%)

Merging #2197 into master will increase coverage by 0.01%

Powered by Codecov. Last update cacd038...f68dc30

Copy link

@kmike kmike commented Aug 24, 2016

Nice catch, thanks @thomdixon!

@kmike kmike changed the title Correct documentation about Response parameters [MRG+1] Correct documentation about Response parameters Aug 24, 2016
Copy link

@eliasdorneles eliasdorneles commented Aug 29, 2016

This is a good fix, thanks.

An even better fix will be to move these docs to docstrings in the code and use autodocs here, but that can be done in a follow-up.
I've been meaning to do that for a while since #713 and this gives me more motivation to get back on it -- so double thanks.

@eliasdorneles eliasdorneles merged commit 1e95bf5 into scrapy:master Aug 29, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing cacd038...f68dc30
codecov/project 83.40% (+0.01%) compared to cacd038
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.