[MRG+1] Fix JsonWriterPipeline example in docs #2302
Merged
Conversation
Current coverage is 83.31% (diff: 100%)@@ master #2302 diff @@
==========================================
Files 161 161
Lines 8719 8719
Methods 0 0
Messages 0 0
Branches 1284 1284
==========================================
+ Hits 6972 7264 +292
+ Misses 1496 1204 -292
Partials 251 251
|
Hey @Granitas, Yeah, the example is not correct; this is mentioned in the note to the next example. It is better to either to fix the example and remove the note, or move the note closer to JsonWriterPipeline example. |
@Granitas , the example definitely needs fixing, thanks for this. |
@redapple I'm talking about this note:
|
Oh, right, I didn't even see the note on GitHub. |
Got rid of the comment, it was really weirdly placed so I didn't even notice it. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The current example does not save the file properly if crawler is called from within a script since file object is never closed.
related stackoverflow question: http://stackoverflow.com/questions/39821693/scrapy-print-pipeline-data-in-a-scripts-context