Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Better explain middleware orders and processing directions #2329

Merged
merged 3 commits into from Oct 20, 2016

Conversation

@josericardo
Copy link
Contributor

@josericardo josericardo commented Oct 18, 2016

It should fix #2262

josericardo added 2 commits Oct 18, 2016
Add more details, making it easier to understand what are the effects of
setting a downloader middleware order.
Expliciting what actually happens by adding links to the respective methods
that are invoked in each processing phase.
@josericardo
Copy link
Contributor Author

@josericardo josericardo commented Oct 18, 2016

It's not exactly what @redapple suggested on #2202. What do you think of this alternative?

Copy link
Contributor

@redapple redapple left a comment

Looks better @josericardo ! Thanks.
Would is be possible to add a section on spider middleware orders too? (in docs/topics/spider-middleware.rst probably)

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 18, 2016

Current coverage is 83.31% (diff: 100%)

Merging #2329 into master will not change coverage

@@             master      #2329   diff @@
==========================================
  Files           161        161          
  Lines          8721       8721          
  Methods           0          0          
  Messages          0          0          
  Branches       1284       1284          
==========================================
  Hits           7266       7266          
  Misses         1204       1204          
  Partials        251        251          

Powered by Codecov. Last update 7e20725...e12e364

Document the effects of the middleware order in a more detailed way.
@josericardo
Copy link
Contributor Author

@josericardo josericardo commented Oct 18, 2016

@redapple Sure: e12e364 :)

@redapple redapple changed the title Better explain middleware orders and processing directions [MRG+1] Better explain middleware orders and processing directions Oct 18, 2016
@kmike kmike merged commit 71c8278 into scrapy:master Oct 20, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 7e20725...e12e364
Details
codecov/project 83.31% (+0.00%) compared to 7e20725
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants