[MRG+1] Added a note about invalid spider names in python 2 (fixes #2251) #2330
Conversation
kmike
changed the title
|
Looks good to me, thanks! |
Current coverage is 83.31% (diff: 100%)@@ master #2330 diff @@
==========================================
Files 161 161
Lines 8721 8721
Methods 0 0
Messages 0 0
Branches 1284 1284
==========================================
Hits 7266 7266
Misses 1204 1204
Partials 251 251
|
|
Thanks @lfmattossch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
'Sup guys,
This adds a note to the documentation fixing the issue #2251
Does it looks good?
Thnaks!