Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Added a note about invalid spider names in python 2 (fixes #2251) #2330

Merged
merged 1 commit into from Oct 18, 2016

Conversation

@lfmattossch
Copy link
Contributor

@lfmattossch lfmattossch commented Oct 18, 2016

'Sup guys,

This adds a note to the documentation fixing the issue #2251

Does it looks good?

Thnaks!

@kmike kmike added the docs label Oct 18, 2016
@kmike kmike changed the title Added a note about invalid spider names in python 2 (fixes #2251) [MRG+1] Added a note about invalid spider names in python 2 (fixes #2251) Oct 18, 2016
@kmike
Copy link
Member

@kmike kmike commented Oct 18, 2016

Looks good to me, thanks!

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 18, 2016

Current coverage is 83.31% (diff: 100%)

Merging #2330 into master will not change coverage

@@             master      #2330   diff @@
==========================================
  Files           161        161          
  Lines          8721       8721          
  Methods           0          0          
  Messages          0          0          
  Branches       1284       1284          
==========================================
  Hits           7266       7266          
  Misses         1204       1204          
  Partials        251        251          

Powered by Codecov. Last update 7e20725...7c33e0c

@redapple redapple merged commit 6cc83c0 into scrapy:master Oct 18, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 7e20725...7c33e0c
Details
codecov/project 83.31% (+0.00%) compared to 7e20725
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple
Copy link
Contributor

@redapple redapple commented Oct 18, 2016

Thanks @lfmattossch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.