[MRG+1] data URI download handler. #2334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
+ Coverage 83.9% 83.95% +0.04%
==========================================
Files 161 162 +1
Lines 8893 8935 +42
Branches 1312 1317 +5
==========================================
+ Hits 7462 7501 +39
Misses 1176 1176
- Partials 255 258 +3
Continue to review full report at Codecov.
|
@ArturGaspar , w3lib 1.17 will be released soon (see scrapy/w3lib#87) |
@ArturGaspar , I relaunched the Travis builds with w3lib 1.17. All green :) |
|
This PR should bump required minimum w3lib version to 1.17 in scrapy's setup.py |
Could you please rebase it on master? There was a few other places w3lib version should be bumped, and a few other pull requests which needed this bump, so the required w3lib version is now increased in master. |
@ArturGaspar looks good! Could you please add a test (or modify an existing test) to check other Response attributes: url, headers? |
Looks good, thanks @ArturGaspar! |
GitHub does not let me change head branch in #2175, so I have to open a new PR.
Fixes #2156