Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] doc: wording #2354

Merged
merged 2 commits into from Oct 24, 2016
Merged

[MRG+1] doc: wording #2354

merged 2 commits into from Oct 24, 2016

Conversation

@stav
Copy link
Contributor

@stav stav commented Oct 21, 2016

Am I being pedantic about wanting to change the word "constructor" to "initializer"?

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 21, 2016

Current coverage is 83.31% (diff: 100%)

Merging #2354 into master will not change coverage

@@             master      #2354   diff @@
==========================================
  Files           161        161          
  Lines          8721       8721          
  Methods           0          0          
  Messages          0          0          
  Branches       1284       1284          
==========================================
  Hits           7266       7266          
  Misses         1204       1204          
  Partials        251        251          

Powered by Codecov. Last update 1be2447...99daea4

@kmike
Copy link
Member

@kmike kmike commented Oct 21, 2016

No, see #2218 :)
I like "__init__ method" more than "initializer", it is easier to understand.

See also: https://github.com/scrapy/scrapy/search?p=1&q=constructor&utf8=%E2%9C%93, https://github.com/scrapy/scrapy/search?utf8=%E2%9C%93&q=constructors&type=Code

@kmike kmike changed the title doc: wording [MRG+1] doc: wording Oct 22, 2016
@redapple redapple merged commit bd4f156 into scrapy:master Oct 24, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 1be2447...99daea4
Details
codecov/project 83.31% (+0.00%) compared to 1be2447
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants