[MRG+1] Ignore explicitly compiled python files.

[rmax]

This avoids to include compiled files in the templates directory.

Without this change, pyc files in the templates are included in the build:

$ find build | grep pyc
build/lib/scrapy/templates/project/module/__init__.pyc
build/lib/scrapy/templates/project/module/spiders/__init__.pyc

[codecov-io]

Current coverage is 83.36% (diff: 100%)

Merging #2386 into master will not change coverage

@@             master      #2386   diff @@
==========================================
  Files           161        161          
  Lines          8723       8723          
  Methods           0          0          
  Messages          0          0          
  Branches       1285       1285          
==========================================
  Hits           7272       7272          
  Misses         1201       1201          
  Partials        250        250          

Powered by Codecov. Last update ea83e67...3cd56da

[kmike]

@rolando could you please explain why are pyc files a problem?

[rmax]

@kmike IMO, it leaves the build dirty as only templates directory have pyc files. But, particularly this was breaking the conda-forge build on windows: conda-forge/staged-recipes#1646 (comment)

The conda build scripts cleaned up pyc files, but not in the templates directory. So when attempting to recreate pyc files it failed because templates already had pyc files around.

[kmike]

I am cautious because not having pyc files in install directory means Python will try to create them on first run, and it can be a problem if filesystem permissions don't allow that. Package installation could happen with write access, but user may have only read access.

But apparently setuptools (or is it distutils? or pip?) creates them during the install. Could you please confirm that manifest changes don't prevent pyc file creation during installation?

[rmax]

@kmike The Manifest.in is only for sdist command: https://docs.python.org/2/distutils/sourcedist.html#the-manifest-in-template

The sdist output already does not include any pyc file except those two listed above, which usually don't cause a problem because the installers (or binary packaging tools) compile all pyc files for the given platform.

This PR only aims to have a clean source distribution without any pyc file (those two files listed above).

PD: The source distribution package does not include pyc files but default, but given templates are data directories those two pyc get included.

[kmike]

Ok, thanks for clarifying it!