Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Print more dependencies versions in "scrapy version" verbose output #2404

Merged
merged 1 commit into from Nov 30, 2016

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Nov 22, 2016

No description provided.

@redapple redapple added this to the v1.3 milestone Nov 22, 2016
@redapple
Copy link
Contributor Author

@redapple redapple commented Nov 22, 2016

In theory, scrapy requires w3lib>=1.15 so the try/except may not be needed.
(You never know what users may end up with though)

@kmike
Copy link
Member

@kmike kmike commented Nov 22, 2016

What do you think about adding optional dependencies? boto / botocore / Pillow, anything else?

@kmike
Copy link
Member

@kmike kmike commented Nov 22, 2016

I also think that's fine to have this feature in Scrapy 1.2.x

@redapple
Copy link
Contributor Author

@redapple redapple commented Nov 22, 2016

Good idea about adding the optional dependencies too. Another PR maybe?

@redapple
Copy link
Contributor Author

@redapple redapple commented Nov 22, 2016

I also think that's fine to have this feature in Scrapy 1.2.x

Right, we can still do that. We haven't started 1.3.x

@redapple redapple removed this from the v1.3 milestone Nov 22, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 22, 2016

Current coverage is 83.37% (diff: 80.00%)

Merging #2404 into master will decrease coverage by <.01%

@@             master      #2404   diff @@
==========================================
  Files           161        161          
  Lines          8732       8742    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       1285       1285          
==========================================
+ Hits           7281       7289     +8   
- Misses         1201       1203     +2   
  Partials        250        250          

Powered by Codecov. Last update a07400c...01142e2

@kmike kmike changed the title Print more dependencies versions in "scrapy version" verbose output [MRG+1] Print more dependencies versions in "scrapy version" verbose output Nov 22, 2016
@kmike kmike added this to the v1.2.2 milestone Nov 30, 2016
@kmike kmike merged commit bba4645 into scrapy:master Nov 30, 2016
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants