Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix #396 re-triggered issue #2418

Merged
merged 1 commit into from Nov 30, 2016

Conversation

@ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Nov 30, 2016

The InteractiveShellEmbed class is a singleton
and we need to drop the instance with its clear_instance() method
to rebuild the instance from scratch with fresh environment
for each subsequent Scrapy's shell drop in.

The InteractiveShellEmbed class is a singleton
and we need to drop the instance with its clear_instance() method
to rebuild the instance from scratch with fresh environment
for each subsequent Scrapy's shell drop in.
@redapple
Copy link
Contributor

@redapple redapple commented Nov 30, 2016

(you can discard the appveyor build error)

@redapple redapple changed the title Fix #396 re-triggered issue [MRG+1] Fix #396 re-triggered issue Nov 30, 2016
@redapple redapple added this to the v1.2.2 milestone Nov 30, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Nov 30, 2016

Looks good to me, thanks @ahlinc @redapple @Tarliton !

@eliasdorneles eliasdorneles merged commit 2086ff4 into scrapy:master Nov 30, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tarliton
Copy link

@Tarliton Tarliton commented Nov 30, 2016

thank you all for solving this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.