[MRG] Support kwargs for response.xpath() #2457
@@ Coverage Diff @@ ## master #2457 +/- ## ======================================= Coverage 83.49% 83.49% ======================================= Files 161 161 Lines 8787 8787 Branches 1289 1289 ======================================= Hits 7337 7337 Misses 1203 1203 Partials 247 247
We have two options:
(2) looks like a no-brainer for me - parsel is a pure-Python package, and there are no breaking changes, while (1) requires user to think twice and check what's this 'parsel' thing and what is the installed version :)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.