Is it strictly needed? For those not using kwargs, 0.9.5<=parsel<1.1 should work fine.
I thought setup.py was about the absolute minimum required version.
No strong opinion on that though, since parsel 1.1 is better.
document that this feature requires a more recent parsel;
bump parsel version.
(2) looks like a no-brainer for me - parsel is a pure-Python package, and there are no breaking changes, while (1) requires user to think twice and check what's this 'parsel' thing and what is the installed version :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
Allow passing named variables and
namespaces
dict arguments on.xpath()
shortcut, now that scrapy/parsel#45 is merged