[MRG+1] ENH Pass arguments to logger rather than formatted message. #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This not only use the standard form but helps error aggregation libraries (i.e.: Sentry) to avoid duplicating the message.
Current coverage is 83.42% (diff: 100%)@@ master #2458 diff @@
==========================================
Files 161 161
Lines 8761 8762 +1
Methods 0 0
Messages 0 0
Branches 1286 1286
==========================================
+ Hits 7309 7310 +1
Misses 1204 1204
Partials 248 248
|
|
I think this change is fine. As a side not, see also: #1626 |
kmike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only use the standard form but helps error aggregation
libraries (i.e.: Sentry) to avoid duplicating the message.