Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] docs: installation instructions, mention conda in the beginning (closes #2475) #2477

Merged
merged 1 commit into from Mar 9, 2017

Conversation

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 3, 2017

Hey fellows,

As I commented in #2475 , I've installed Windows in a VM to test Scrapy installation.

Sure enough, Conda seems the easiest way, I've had no problems at all with it.

As for PyPI, I was unable to test it: I couldn't even get Python to work without Anaconda (CPython installation kept freezing). :(

Anyway, I know this is just a data point, but given the trouble that is installing and compiling stuff on Windows, I think it makes sense to mention the conda option right in the beginning and to remove all the complication about setting up Python on Windows.

What do you think?

@redapple redapple added the in progress label Jan 3, 2017
@eliasdorneles
Copy link
Member Author

@eliasdorneles eliasdorneles commented Jan 3, 2017

Btw, here is a screenshot of Scrapy working under Py3 and Win:

scrapy-py3-win-2

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 3, 2017

Current coverage is 83.45% (diff: 100%)

Merging #2477 into master will not change coverage

@@             master      #2477   diff @@
==========================================
  Files           161        161          
  Lines          8780       8780          
  Methods           0          0          
  Messages          0          0          
  Branches       1288       1288          
==========================================
  Hits           7327       7327          
  Misses         1205       1205          
  Partials        248        248          

Powered by Codecov. Last update e7dede6...b6ab1ae

Copy link
Contributor

@redapple redapple left a comment

Thanks @eliasdorneles !

@redapple redapple changed the title docs: installation instructions, mention conda in the beginning (closes #2475) [MRG+1] docs: installation instructions, mention conda in the beginning (closes #2475) Jan 4, 2017
@kmike kmike changed the title [MRG+1] docs: installation instructions, mention conda in the beginning (closes #2475) [MRG+2] docs: installation instructions, mention conda in the beginning (closes #2475) Mar 1, 2017
@kmike
Copy link
Member

@kmike kmike commented Mar 1, 2017

I'm not anaconda user myself, but I'm fine with this fix as soon as there is someone around in the issue tracker who can help in case of problems.

@redapple redapple added this to the v1.4 milestone Mar 9, 2017
@redapple redapple merged commit 36160f1 into master Mar 9, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing e7dede6...b6ab1ae
Details
codecov/project 83.45% (+0.00%) compared to e7dede6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple deleted the recommend-anaconda-for-win branch May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants