[MRG] Buffer CONNECT response bytes from proxy until all HTTP headers are received #2495
@@ Coverage Diff @@ ## master #2495 +/- ## ========================================== - Coverage 83.46% 83.44% -0.02% ========================================== Files 161 161 Lines 8780 8784 +4 Branches 1288 1289 +1 ========================================== + Hits 7328 7330 +2 - Misses 1204 1205 +1 - Partials 248 249 +1
LGTM. Relevant document: http://www.freeproxy.ru/ru/free_proxy/faq/draft-luotonen-web-proxy-tunneling-01.txt:
so this PR does as specified - waits for an empty line.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.