Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix view command against new --no-redirect option #2503

Merged
merged 3 commits into from Feb 2, 2017

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Jan 19, 2017

Fixes #2501

To do:

  • Update docs about --no-redirect for view command
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 19, 2017

Codecov Report

Merging #2503 into master will increase coverage by 0.01%.

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
+ Coverage   83.45%   83.46%   +0.01%     
==========================================
  Files         161      161              
  Lines        8780     8780              
  Branches     1288     1288              
==========================================
+ Hits         7327     7328       +1     
+ Misses       1205     1204       -1     
  Partials      248      248
Impacted Files Coverage Δ
scrapy/commands/view.py 58.33% <ø> (ø)
scrapy/utils/python.py 85.45% <ø> (ø)
scrapy/linkextractors/regex.py 95.65% <ø> (+4.34%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5586fc7...4156a86. Read the comment docs.

@redapple
Copy link
Contributor Author

@redapple redapple commented Jan 19, 2017

hm, this adds --headers option to scrapy view, which does not make much sense. Might as well go with #2502

@redapple
Copy link
Contributor Author

@redapple redapple commented Jan 30, 2017

So I just removed the --headers option from the option parser.

@redapple redapple changed the title Fix view command against new --no-redirect option [MRG] Fix view command against new --no-redirect option Jan 31, 2017
@kmike
Copy link
Member

@kmike kmike commented Feb 2, 2017

Thanks @redapple!

@kmike kmike merged commit c305c46 into scrapy:master Feb 2, 2017
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 83.45%)
Details
codecov/project 83.46% (+0.01%) compared to 5586fc7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple deleted the redapple:view-no-redirect branch Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.