Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Support 'True' and 'False' strings as boolean settings values #2519

Merged
merged 1 commit into from Feb 2, 2017

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Jan 30, 2017

Revisiting #743

Fixes #2517

@kmike kmike changed the title Support 'True' and 'False' strings as boolean settings values [MRG+1] Support 'True' and 'False' strings as boolean settings values Feb 2, 2017
@kmike
Copy link
Member

@kmike kmike commented Feb 2, 2017

Merging it as per #743 (comment) :) Thanks @redapple!

@kmike kmike merged commit d4a8f43 into scrapy:master Feb 2, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 83.46%)
Details
codecov/project 83.47% (+0.01%) compared to 4ca191e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple deleted the redapple:settings-getbool-new branch Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants