Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Use yield with nested parsing of responses #2533

Merged
merged 1 commit into from Feb 8, 2017

Conversation

@djrobust
Copy link
Contributor

@djrobust djrobust commented Feb 5, 2017

In my project I found that return made the spider terminate early, while yield worked as intended. yield is also used throughout other examples of the parse function in the documentation, so even if functionality is similar, using yield in this example improves consistency.

Use 'yield' consistently across examples of parse functions.
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 5, 2017

Codecov Report

Merging #2533 into master will increase coverage by -0.05%.

@@            Coverage Diff             @@
##           master    #2533      +/-   ##
==========================================
- Coverage   83.49%   83.45%   -0.05%     
==========================================
  Files         161      161              
  Lines        8787     8780       -7     
  Branches     1289     1288       -1     
==========================================
- Hits         7337     7327      -10     
- Misses       1203     1205       +2     
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/resolver.py 80% <ø> (-9.48%)
scrapy/linkextractors/regex.py 91.3% <ø> (-4.35%)
scrapy/settings/init.py 96.41% <ø> (-0.15%)
scrapy/commands/view.py 58.33% <ø> (ø)
scrapy/utils/python.py 85.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8e6d4...3021084. Read the comment docs.

@kmike kmike changed the title Use yield with nested parsing of responses [MRG+1] Use yield with nested parsing of responses Feb 6, 2017
@kmike
Copy link
Member

@kmike kmike commented Feb 6, 2017

I think this change is fine.

@kmike kmike changed the base branch from 1.3 to master Feb 6, 2017
@redapple redapple merged commit 7d0b890 into scrapy:master Feb 8, 2017
2 of 3 checks passed
2 of 3 checks passed
codecov/project 83.45% (-0.05%) compared to 3b8e6d4
Details
codecov/patch Coverage not affected when comparing 3b8e6d4...3021084
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants