[MRG+1] FormRequest: handle whitespaces in action attribute properly #2548
Conversation
| @@ -51,7 +54,10 @@ def from_response(cls, response, formname=None, formid=None, formnumber=0, formd | |||
|
|
|||
| def _get_form_url(form, url): | |||
| if url is None: | |||
| return urljoin(form.base_url, form.action) | |||
kmike
Feb 8, 2017
Author
Member
this urljoin was pointless because form.action already calls urljoin(form.base_url, action)
this urljoin was pointless because form.action already calls urljoin(form.base_url, action)
redapple
changed the title
Merged
Codecov Report
@@ Coverage Diff @@
## master #2548 +/- ##
==========================================
+ Coverage 83.59% 83.59% +<.01%
==========================================
Files 161 161
Lines 8812 8816 +4
Branches 1296 1297 +1
==========================================
+ Hits 7366 7370 +4
Misses 1200 1200
Partials 246 246
Continue to review full report at Codecov.
|
|
Rebased on top of #2559. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It requires w3lib 0.17.0+, but I haven't bumped the requirement in this PR.