Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] FormRequest: handle whitespaces in action attribute properly #2548

Merged
merged 2 commits into from Feb 20, 2017

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 8, 2017

It requires w3lib 0.17.0+, but I haven't bumped the requirement in this PR.

@@ -51,7 +54,10 @@ def from_response(cls, response, formname=None, formid=None, formnumber=0, formd

def _get_form_url(form, url):
if url is None:
return urljoin(form.base_url, form.action)

This comment has been minimized.

@kmike

kmike Feb 8, 2017
Author Member

this urljoin was pointless because form.action already calls urljoin(form.base_url, action)

@redapple redapple changed the title FormRequest: handle whitespaces in action attribute properly [MRG+1] FormRequest: handle whitespaces in action attribute properly Feb 10, 2017
@kmike kmike mentioned this pull request Feb 13, 2017
@kmike kmike force-pushed the formrequest-whitespaces branch from ade7c5d to 074caf4 Feb 15, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 15, 2017

Codecov Report

Merging #2548 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
+ Coverage   83.59%   83.59%   +<.01%     
==========================================
  Files         161      161              
  Lines        8812     8816       +4     
  Branches     1296     1297       +1     
==========================================
+ Hits         7366     7370       +4     
  Misses       1200     1200              
  Partials      246      246
Impacted Files Coverage Δ
scrapy/http/request/form.py 95.9% <100%> (+0.13%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afac3fd...074caf4. Read the comment docs.

@kmike
Copy link
Member Author

@kmike kmike commented Feb 15, 2017

Rebased on top of #2559.

@dangra dangra merged commit 322fd68 into master Feb 20, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 83.59%)
Details
codecov/project 83.59% (+<.01%) compared to afac3fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the formrequest-whitespaces branch Feb 20, 2017
@dangra dangra added this to the v1.4 milestone Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants