Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility with twisted 17+ #2558

Merged
merged 2 commits into from Feb 13, 2017
Merged

Fixed compatibility with twisted 17+ #2558

merged 2 commits into from Feb 13, 2017

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 13, 2017

I've replaced try/except with explicit version checks and ported code to be compatible with Twisted 17+. This should fix #2555.

For the record, issue was caused by https://twistedmatrix.com/trac/ticket/8916.

Also, we no longer support Ubuntu 12.04, so its tox environment is replaced with Ubuntu 14.04 environment (we still don't run it on Travis though).

@redapple
Copy link
Contributor

@redapple redapple commented Feb 13, 2017

@dangra dangra merged commit 45f1902 into master Feb 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the twisted-17-fix branch Feb 13, 2017
@pawelmhm
Copy link
Contributor

@pawelmhm pawelmhm commented Feb 15, 2017

should we add more tests for https so that potential problems will be detected easier? Seems like our test suite passed ok with Twisted 17 so apparently our tests are not covering situation that occurred. I understand unit testing TLS bugs is probably not easy, but maybe we could find some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.