[MRG+1] Separate building request from _requests_to_follow in CrawlSpider #2562
scrapy-splash's request is following:
What do you think about that? Should I implement new spider?
Thank you for your reply. I saw #1495.
I agree with you and I think this method should be private for now because this method isn't referred to by other object in many case. In addition, someone who wants to change request object would be able to override this method and
def _make_first_request(self, url): return Request(url, dont_filter=True) def _make_following_request(self, url): return Request(url=url, callback=self._response_downloaded)
Maybe it is better to have a method to build many kinds of requests but that method would be too complicated because of many arguments.