Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] HttpErrorMiddleware stats #2566

Merged
merged 1 commit into from Feb 22, 2017
Merged

[MRG+1] HttpErrorMiddleware stats #2566

merged 1 commit into from Feb 22, 2017

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 15, 2017

Similar to #2543.

@dangra dangra added this to the v1.4 milestone Feb 20, 2017
@@ -46,6 +46,10 @@ def process_spider_input(self, response, spider):

def process_spider_exception(self, response, exception, spider):
if isinstance(exception, HttpError):
spider.crawler.stats.inc_value('httperror/response_dropped_count')
spider.crawler.stats.inc_value(

This comment has been minimized.

@redapple

redapple Feb 22, 2017
Contributor

Maybe it should use the same "ignored" term as the subsequent INFO message ("Ignoring" is also in the HttpError exception message) instead of "dropped".
Besides that small nitpick, looks good to me.

This comment has been minimized.

@kmike

kmike Feb 22, 2017
Author Member

@redapple updated, thanks for the suggestion!

@kmike kmike force-pushed the httperror-stats branch from 2e02a32 to 26c1256 Feb 22, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 22, 2017

Codecov Report

Merging #2566 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   83.59%   83.59%   +<.01%     
==========================================
  Files         161      161              
  Lines        8812     8814       +2     
  Branches     1296     1296              
==========================================
+ Hits         7366     7368       +2     
  Misses       1200     1200              
  Partials      246      246
Impacted Files Coverage Δ
scrapy/spidermiddlewares/httperror.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac5119...26c1256. Read the comment docs.

@redapple redapple changed the title HttpErrorMiddleware stats [MRG+1] HttpErrorMiddleware stats Feb 22, 2017
@kmike kmike merged commit ce8a9aa into master Feb 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike deleted the httperror-stats branch Feb 22, 2017
@kmike kmike mentioned this pull request Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants