Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST fixed ProjectUtilsTest on OS X #2569

Merged
merged 1 commit into from Feb 20, 2017
Merged

TST fixed ProjectUtilsTest on OS X #2569

merged 1 commit into from Feb 20, 2017

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 16, 2017

Temp folder can be a symlink on OS X; tests failed for me with this exception:

tests/test_utils_project.py F.

================================================================== FAILURES ===================================================================
_______________________________________________ ProjectUtilsTest.test_data_path_inside_project ________________________________________________

self = <tests.test_utils_project.ProjectUtilsTest testMethod=test_data_path_inside_project>

    def test_data_path_inside_project(self):
        with inside_a_project() as proj_path:
            expected = os.path.join(proj_path, '.scrapy', 'somepath')
>           self.assertEquals(expected, data_path('somepath'))
E           AssertionError: '/var/folders/_5/cbsg50991szfp1r9nwxpx85800[31 chars]path' != '/private/var/folders/_5/cbsg50991szfp1r9nw[39 chars]path'
E           - /var/folders/_5/cbsg50991szfp1r9nwxpx8580000gn/T/tmp_v300tga/.scrapy/somepath
E           + /private/var/folders/_5/cbsg50991szfp1r9nwxpx8580000gn/T/tmp_v300tga/.scrapy/somepath
E           ? ++++++++

This PR fixed that.

Temp folder can be a symlink on OS X.
@dangra dangra merged commit b15b454 into master Feb 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the fix-project-util-test-osx branch Feb 20, 2017
@dangra dangra added this to the v1.4 milestone Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.