Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] document issue with FormRequest.from_response due to bug in lxml #2572

Merged
merged 1 commit into from Feb 20, 2017

Conversation

@ashkulz
Copy link
Contributor

@ashkulz ashkulz commented Feb 17, 2017

This can make the spider fail due to incorrect values being posted server-side, which is extremely hard to debug because it is easy to miss leading/trailing whitespace, even with a logging proxy.

The fix was merged for lxml 3.8 in lxml/lxml#228 so document that as well.

This can make the spider fail due to incorrect values being posted
server-side, which is extremely hard to debug because it is easy
to miss leading/trailing whitespace, even with a logging proxy.

The fix was merged for lxml 3.8 in lxml/lxml#228 so document that
as well.
@kmike kmike changed the title document issue with FormRequest.from_response due to bug in lxml [MRG+1] document issue with FormRequest.from_response due to bug in lxml Feb 17, 2017
@kmike
Copy link
Member

@kmike kmike commented Feb 17, 2017

A good catch, thanks @ashkulz!

@kmike kmike added the docs label Feb 17, 2017
@dangra dangra merged commit fab168b into scrapy:master Feb 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra added this to the v1.4 milestone Feb 20, 2017
@ashkulz ashkulz deleted the advarisk:warning-formrequest-from-response branch Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.