Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Document ftp_user and ftp_password meta keys #2587

Merged
merged 2 commits into from Mar 1, 2017

Conversation

@MikeinRealLife
Copy link
Contributor

@MikeinRealLife MikeinRealLife commented Feb 23, 2017

Fixes #2574

removed duplicate line
@kfc35
kfc35 approved these changes Feb 23, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 23, 2017

Codecov Report

Merging #2587 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2587   +/-   ##
======================================
  Coverage    83.9%   83.9%           
======================================
  Files         161     161           
  Lines        8893    8893           
  Branches     1312    1312           
======================================
  Hits         7462    7462           
  Misses       1176    1176           
  Partials      255     255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8a9aa...441f255. Read the comment docs.

@kmike kmike changed the title fixed ticket #2574 [MRG+1] fixed ticket #2574 Feb 27, 2017
@kmike kmike added this to the v1.4 milestone Feb 27, 2017
@redapple redapple changed the title [MRG+1] fixed ticket #2574 [MRG+1] Document ftp_user and ftp_password meta keys Mar 1, 2017
@redapple redapple merged commit 2f28cb3 into scrapy:master Mar 1, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing ce8a9aa...441f255
Details
codecov/project 83.9% remains the same compared to ce8a9aa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.