Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FTP downloader and re-enable FTP tests on Python 3 #2599

Merged
merged 1 commit into from Feb 28, 2017

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Feb 27, 2017

FTP support on Python 3 is available again with Twisted 17.1+

@@ -687,9 +687,6 @@ class BaseFTPTestCase(unittest.TestCase):
password = "passwd"
req_meta = {"ftp_user": username, "ftp_password": password}

if six.PY3:
skip = "Twisted missing ftp support for PY3"

This comment has been minimized.

@kmike

kmike Feb 27, 2017
Member

Do you think it still should be skipped for unsupported Twisted versions in Python 3? Or do we support only latest Twisted in Python 3?

This comment has been minimized.

@redapple

redapple Feb 28, 2017
Author Contributor

The current tox/Travis builds use the latest Twisted version when Python 3 is used.
I don't think we need to skip the FTP tests, but we can do it if you think it's cleaner.

This comment has been minimized.

@kmike

kmike Feb 28, 2017
Member

Ok, sounds fine! Thanks for the fix.

@redapple redapple changed the title Re-enable FTP tests on Python 3 Fix FTP downloader and re-enable FTP tests on Python 3 Feb 28, 2017
@kmike kmike merged commit 0e5ed21 into scrapy:master Feb 28, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants