Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant slot.add_request() call in ExecutionEngine #2617

Merged
merged 1 commit into from Mar 3, 2017

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Mar 3, 2017

The slot.add_request(request) in download() is also done in _download() which is called right after.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 3, 2017

Codecov Report

Merging #2617 into master will decrease coverage by -0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2617      +/-   ##
==========================================
- Coverage   84.14%   84.14%   -0.01%     
==========================================
  Files         161      161              
  Lines        9063     9061       -2     
  Branches     1344     1344              
==========================================
- Hits         7626     7624       -2     
  Misses       1177     1177              
  Partials      260      260
Impacted Files Coverage Δ
scrapy/core/engine.py 92.3% <100%> (-0.07%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8453c...30d812e. Read the comment docs.

@kmike kmike merged commit 2c5fa0c into scrapy:master Mar 3, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 84.14%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +15.85% compared to 7e8453c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike
Copy link
Member

@kmike kmike commented Mar 3, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.