[MRG+1] Add sphinx_rtd_theme to docs setup readme #2668
Conversation
What about adding a |
@redapple Yes, I too thought of the same. :) |
I think it would still be easier to |
Sure @redapple , adding right away. |
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 162 162
Lines 9122 9122
Branches 1353 1353
=======================================
Hits 7723 7723
Misses 1141 1141
Partials 258 258 Continue to review full report at Codecov.
|
@@ -15,7 +15,7 @@ and all its dependencies run | |||
|
|||
:: | |||
|
|||
pip install 'Sphinx >= 1.3' sphinx_rtd_theme | |||
pip install -r requirements.txt |
redapple
Mar 20, 2017
Contributor
I'm not sure that it's clear that you would run this inside scrapy/docs/
I'm not sure that it's clear that you would run this inside scrapy/docs/
harshasrinivas
Mar 20, 2017
Author
Contributor
Just like the Compile the documentation
part of this README, to maintain uniformity shall I mention "run the following command from this dir"?
Just like the Compile the documentation
part of this README, to maintain uniformity shall I mention "run the following command from this dir"?
redapple
Mar 21, 2017
Contributor
That would not hurt indeed.
That would not hurt indeed.
Looks good to me. |
Concerns Sphinx 1.4 release #1893 .
sphinx_rtd_theme
has to be installed manually.