Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Update spiders.rst #2670

Merged
merged 2 commits into from May 18, 2017
Merged

[MRG+1] Update spiders.rst #2670

merged 2 commits into from May 18, 2017

Conversation

@qhuang872
Copy link
Contributor

@qhuang872 qhuang872 commented Mar 21, 2017

Added a note to allowed_domains attribute, reminding users not to add urls into the list.

qhuang872 added 2 commits Mar 21, 2017
Added a note to allowed_domains attribute, reminding users not to add urls into the list.
Added note to allowed_domain attribute with an example explaining what goes in the list
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 21, 2017

Codecov Report

Merging #2670 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2670   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         162      162           
  Lines        9122     9122           
  Branches     1353     1353           
=======================================
  Hits         7723     7723           
  Misses       1141     1141           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec55799...8ecc307. Read the comment docs.

@kmike kmike changed the title Update spiders.rst [MRG+1] Update spiders.rst May 5, 2017
@kmike
Copy link
Member

@kmike kmike commented May 5, 2017

I like putting such examples to docs 👍

@dangra dangra merged commit b9d3b44 into scrapy:master May 18, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra added this to the v1.4 milestone May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.