Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Mention how to disable request filtering in documentation of DUPEFILTER_CLASS setting #2714

Merged
merged 1 commit into from Apr 24, 2017

Conversation

@tbcardoso
Copy link
Contributor

@tbcardoso tbcardoso commented Apr 22, 2017

I'm a novice scrappy user and I noticed the documentation does not mention how to disable duplicate request filtering in the settings.
This was useful to me recently as a command line option to a spider.
I also added a warning to consider using the dont_filter parameter of Request instead.

@codecov-io
Copy link

@codecov-io codecov-io commented Apr 22, 2017

Codecov Report

Merging #2714 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
+ Coverage   84.65%   84.66%   +0.01%     
==========================================
  Files         162      162              
  Lines        9122     9122              
  Branches     1353     1353              
==========================================
+ Hits         7722     7723       +1     
  Misses       1141     1141              
+ Partials      259      258       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dee913...00ee9ea. Read the comment docs.

@kmike kmike changed the title Mention how to disable request filtering in documentation of DUPEFILTER_CLASS setting [MRG+1] Mention how to disable request filtering in documentation of DUPEFILTER_CLASS setting Apr 23, 2017
@kmike
Copy link
Member

@kmike kmike commented Apr 23, 2017

Looks good to me, thanks @tbcardoso for taking time to improve documentation after you've solved the problem!

@redapple redapple merged commit 1e12187 into scrapy:master Apr 24, 2017
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants