Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc: open file with "wb" mode will get an error in python 3 #2729

Merged
merged 1 commit into from May 8, 2017

Conversation

@yandongxu
Copy link
Contributor

@yandongxu yandongxu commented May 8, 2017

python: 3.6.0rc2
scrapy: 1.3.0

output:

TypeError: a bytes-like object is required, not 'str'
@codecov-io
Copy link

@codecov-io codecov-io commented May 8, 2017

Codecov Report

Merging #2729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2729   +/-   ##
======================================
  Coverage    84.7%   84.7%           
======================================
  Files         162     162           
  Lines        9125    9125           
  Branches     1354    1354           
======================================
  Hits         7729    7729           
  Misses       1145    1145           
  Partials      251     251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1cacb...4966dd7. Read the comment docs.

@kmike
Copy link
Member

@kmike kmike commented May 8, 2017

A good catch, thanks!

@kmike kmike merged commit f0122e2 into scrapy:master May 8, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 6c1cacb...4966dd7
Details
codecov/project 84.7% remains the same compared to 6c1cacb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.