Fix doc: open file with "wb" mode will get an error in python 3 #2729
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
======================================
Coverage 84.7% 84.7%
======================================
Files 162 162
Lines 9125 9125
Branches 1354 1354
======================================
Hits 7729 7729
Misses 1145 1145
Partials 251 251 Continue to review full report at Codecov.
|
A good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
python: 3.6.0rc2
scrapy: 1.3.0
output: