Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add support for executing scrapy using -m option of python #2740

Merged
merged 1 commit into from May 18, 2017

Conversation

@luzfcb
Copy link
Contributor

@luzfcb luzfcb commented May 16, 2017

This pull-request enable execute scrapy from python module.

python -m scrapy

On windows, this probably works, too. Although I did not test because I do not have Windows

py -3 -m scrapy
python -m scrapy
@codecov-io
Copy link

@codecov-io codecov-io commented May 16, 2017

Codecov Report

Merging #2740 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2740      +/-   ##
==========================================
- Coverage   84.75%   84.73%   -0.02%     
==========================================
  Files         162      163       +1     
  Lines        9155     9158       +3     
  Branches     1358     1359       +1     
==========================================
+ Hits         7759     7760       +1     
- Misses       1145     1146       +1     
- Partials      251      252       +1
Impacted Files Coverage Δ
scrapy/__main__.py 33.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe6d3d...df7a5c4. Read the comment docs.

@kmike kmike changed the title Add support for executing scrapy using -m option of python [MRG+1] Add support for executing scrapy using -m option of python May 18, 2017
@kmike
Copy link
Member

@kmike kmike commented May 18, 2017

+1 to merge, I also wanted to add this feature.

@luzfcb
Copy link
Contributor Author

@luzfcb luzfcb commented May 18, 2017

For reference, I've learned to do this based on this pull-request, done by one of Python's core commiters

cookiecutter/cookiecutter#788

@redapple redapple merged commit 1438104 into scrapy:master May 18, 2017
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 33.33% of diff hit (target 84.75%)
Details
codecov/project 84.73% (-0.02%) compared to dfe6d3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple added this to the v1.4 milestone May 18, 2017
@luzfcb luzfcb deleted the luzfcb:luzfcb-run-scrapy-from-module branch May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.