Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Added doc for `scrapy.exceptions.DontCloseSpider`. Also fixes inaccurate doc for `scrapy.signals.spider_idle`. #2791

merged 1 commit into from Jul 24, 2017


Copy link

@starrify starrify commented Jun 15, 2017

Resolves #2709

…ate doc for `scrapy.signals.spider_idle`.
Copy link

@codecov-io codecov-io commented Jun 15, 2017

Codecov Report

Merging #2791 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2791   +/-   ##
  Coverage   84.73%   84.73%           
  Files         163      163           
  Lines        9164     9164           
  Branches     1362     1362           
  Hits         7765     7765           
  Misses       1147     1147           
  Partials      252      252
@kmike kmike changed the title Added doc for `scrapy.exceptions.DontCloseSpider`. Also fixes inaccurate doc for `scrapy.signals.spider_idle`. [MRG+1] Added doc for `scrapy.exceptions.DontCloseSpider`. Also fixes inaccurate doc for `scrapy.signals.spider_idle`. Jun 16, 2017
Copy link

@kmike kmike commented Jun 16, 2017

Looks good to me, thanks!

@dangra dangra merged commit d1e948c into scrapy:master Jul 24, 2017
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 5aebdac...f712513
continuous-integration/travis-ci/pr The Travis CI build passed
@kmike kmike added this to the v1.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.