python-attrs support to Scrappy Items #2807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Included corresponding changes in the tests.
…ects with the attr.s decorator can be Scrapy items
…ring the required arguments on the decorator for a consistent behaviour with non-decorated scrapy items.
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 84.73% 84.75% +0.01%
==========================================
Files 163 163
Lines 9164 9175 +11
Branches 1362 1367 +5
==========================================
+ Hits 7765 7776 +11
Misses 1147 1147
Partials 252 252
|
|
Hm, interesting. Your approach makes attribute access work. I was thinking about something a bit different - supporting any class decorated with |
redapple
changed the title
|
Would definitely be interested in support for using |
Closed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #2749
Providing new ways to populate Scrapy items and adding the possibility of having @attr.s decorated Scrappy items.
This PR tries to solve the suggestions presented in issue #2749
Certain arguments need to be passed to the decorator in order to make the decorated class (a subclass of Scrapy Item) compatible with the functioning of Scrapy Items. This is covered in the form of tests in the PR.
At the moment, the passing of default values to the attributes of the class (equivalent to Fields in normal Scrapy Items) is covered, but the passing of other metadata, such as validators, has not been considered.
This PR also covers the dot notation access to the Fields in Scrapy Items.