Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add option to disable automatic log handler install #2921

Merged
merged 1 commit into from Oct 26, 2017

Conversation

revolter
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2017

Codecov Report

Merging #2921 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2921   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         164      164           
  Lines        9192     9192           
  Branches     1370     1370           
=======================================
  Hits         7798     7798           
  Misses       1138     1138           
  Partials      256      256
Impacted Files Coverage Δ
scrapy/crawler.py 91.35% <100%> (ø) ⬆️

@kmike kmike changed the title Add option to disable automatic log handler install [MRG+1] Add option to disable automatic log handler install Sep 28, 2017
@kmike
Copy link
Member

kmike commented Sep 28, 2017

Looks good to me.

@dangra dangra merged commit 1d9c8f5 into scrapy:master Oct 26, 2017
@kmike kmike added this to the v1.5 milestone Dec 22, 2017
@revolter revolter deleted the hotfix/disable-logging branch May 11, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants