Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for external links wherever possible in docs #2978

Merged
merged 1 commit into from Oct 27, 2017

Conversation

@codeaditya
Copy link
Contributor

@codeaditya codeaditya commented Oct 26, 2017

I have manually followed all the http links in docs and converted them to https wherever possible.

I didn't touch links for docs.scrapy.org, scrapy.org and sub-domains of it. Shall we convert them to https too?

@codecov
Copy link

@codecov codecov bot commented Oct 26, 2017

Codecov Report

Merging #2978 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2978   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         164      164           
  Lines        9249     9249           
  Branches     1376     1376           
=======================================
  Hits         7824     7824           
  Misses       1167     1167           
  Partials      258      258
@kmike
Copy link
Member

@kmike kmike commented Oct 27, 2017

Awesome, thanks @codeaditya!

@kmike kmike merged commit 79df51a into scrapy:master Oct 27, 2017
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 1d9c8f5...9dd680d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codeaditya
Copy link
Contributor Author

@codeaditya codeaditya commented Oct 27, 2017

Thanks for merging @kmike .. Would it be fine to use https links for docs.scrapy.org, scrapy.org and other subdomains of scrapy.org? I would be happy to fix them and send another request for it :-)

@kmike
Copy link
Member

@kmike kmike commented Oct 27, 2017

It sounds like a good change to me, but let's confirm it with @dangra.

@dangra
Copy link
Member

@dangra dangra commented Oct 28, 2017

Yes, it is!

@codeaditya
Copy link
Contributor Author

@codeaditya codeaditya commented Oct 28, 2017

Submitted PR #2982

@kmike kmike added this to the v1.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.