Fix broken links and use https links wherever possible #2982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
- Coverage 84.59% 84.58% -0.02%
==========================================
Files 164 164
Lines 9249 9249
Branches 1376 1376
==========================================
- Hits 7824 7823 -1
Misses 1167 1167
- Partials 258 259 +1
|
| @@ -163,7 +163,7 @@ def _get_max_age(self, cc): | |||
|
|
|||
| def _compute_freshness_lifetime(self, response, request, now): | |||
| # Reference nsHttpResponseHead::ComputeFreshnessLifetime | |||
| # http://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpResponseHead.cpp#410 | |||
| # https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpResponseHead.cpp#706 | |||
kmike
Oct 28, 2017
Member
👍
|
Thanks @codeaditya for the careful pull request! |
|
Awesome. Thanks @kmike.. It's been a very pleasurable experience.. Would send a PR for User-Agent too.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I haven't touched scrapy shell commands and other places which have the potential to break something else if not careful. Besides the changes made, I would like to point out two more issues:
https://github.com/scrapy/scrapy/blob/master/scrapy/http/cookies.py#L115 -
WrappedRequestclass mentions and links tourllib2.Request(the link is broken). Since in Python 3 it isurllib.request.Request, I am not sure about the best way to fix this.Shall we switch the default user agent to https as well?