Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Use https link in default user agent #2983

Merged
merged 1 commit into from Nov 2, 2017

Conversation

@codeaditya
Copy link
Contributor

@codeaditya codeaditya commented Oct 28, 2017

No description provided.

@codecov
Copy link

@codecov codecov bot commented Oct 28, 2017

Codecov Report

Merging #2983 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2983      +/-   ##
==========================================
+ Coverage   84.58%   84.59%   +0.01%     
==========================================
  Files         164      164              
  Lines        9249     9249              
  Branches     1376     1376              
==========================================
+ Hits         7823     7824       +1     
  Misses       1167     1167              
+ Partials      259      258       -1
Impacted Files Coverage Δ
scrapy/settings/default_settings.py 98.6% <100%> (ø) ⬆️
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️
@kmike kmike changed the title Use https link in default user agent [MRG+1] Use https link in default user agent Oct 31, 2017
@kmike
Copy link
Member

@kmike kmike commented Oct 31, 2017

Looks good to me, thanks @codeaditya!
This change is technically backwards incompatible, we must be sure to mention it in the changelog.

@codeaditya
Copy link
Contributor Author

@codeaditya codeaditya commented Oct 31, 2017

Yeah @kmike.. docs/news.rst seems to only document changes for released versions. Where do we document this change in development version?

@lopuhin lopuhin merged commit fd73345 into scrapy:master Nov 2, 2017
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 84.58%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codeaditya codeaditya deleted the codeaditya:https-links branch Nov 2, 2017
@kmike kmike added this to the v1.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants