[MRG+1] Revise/modernize item exporter example in docs #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2989 +/- ##
==========================================
+ Coverage 84.58% 84.59% +0.01%
==========================================
Files 164 164
Lines 9249 9249
Branches 1376 1376
==========================================
+ Hits 7823 7824 +1
Misses 1167 1167
+ Partials 259 258 -1
|
kmike
reviewed
Oct 31, 2017
docs/topics/exporters.rst
Outdated
| self.year_to_exporter = {} | ||
|
|
||
| def close_spider(self, spider): | ||
| for exporter in self.year_to_exporter.itervalues(): |
There was a problem hiding this comment.
It should be .values() in order to be compatible with Python 3. Creating a temporary list in Python 2 is not a problem as a list would be small.
kmike
reviewed
Oct 31, 2017
docs/topics/exporters.rst
Outdated
| def _exporter_for_item(self, item): | ||
| year = item['year'] | ||
| if year not in self.year_to_exporter: | ||
| f = open('{}.xml'.format(year), 'w+b') |
There was a problem hiding this comment.
why is 'w+b' needed, not just 'wb'?
There was a problem hiding this comment.
Good call. I just copied it from the previous example, but as you say, it doesn't seem to be necessary.
|
I like the revised example, exporting to several locations is a common problem users ask for 👍 |
kmike
changed the title
|
Looks good to me, thanks @colinmorris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2932
@kmike pointed out that the concept of a file-per-spider no longer made sense, so I changed the use case to one inspired by my own experience. It's maybe a little more complicated than the previous example, but it still comes out to fewer lines of code after removing the overhead of manually connecting the signals.