@@ Coverage Diff @@ ## master #3050 +/- ## ======================================= Coverage 84.51% 84.51% ======================================= Files 164 164 Lines 9270 9270 Branches 1380 1380 ======================================= Hits 7835 7835 Misses 1177 1177 Partials 258 258
Totally unscientific speed comparison (on a slow Xeon, running
Would be good to deploy https://github.com/scrapy/scrapy-bench, benchmarks there are more representative I think.
These built-in functions are exposed as methods in PyPy3. For scrapy this does not matter as: 1) they do not work for CPython at all 2) get_func_args is checked for presense of an argument in scrapy, extra "self" does not matter. But it still makes sense to leave these tests so that we know we shouldn't use get_func_args for built-in functions/methods.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.