Add PyPy3 support #3050
Merged
Add PyPy3 support #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3050 +/- ##
=======================================
Coverage 84.51% 84.51%
=======================================
Files 164 164
Lines 9270 9270
Branches 1380 1380
=======================================
Hits 7835 7835
Misses 1177 1177
Partials 258 258 |
|
Totally unscientific speed comparison (on a slow Xeon, running
Would be good to deploy https://github.com/scrapy/scrapy-bench, benchmarks there are more representative I think. |
These built-in functions are exposed as methods in PyPy3. For scrapy this does not matter as: 1) they do not work for CPython at all 2) get_func_args is checked for presense of an argument in scrapy, extra "self" does not matter. But it still makes sense to leave these tests so that we know we shouldn't use get_func_args for built-in functions/methods.
|
This is almost ready, only waiting for the second pypy3 build to finish to check if it still takes 22 minutes 😱 Right now only Linux binaries are available for PyPy3, so I tested only Linux installation. |
|
pypy3 took 23 minutes again, although the second longest py35 took 15 minutes. Locally, pypy3 took 16 minutes, and I don't have any ideas for quick speedups of the tests. |
kmike
approved these changes
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just checking how they run on Travis. Turns out that lxml on PyPy3 is no longer a problem (
PyPy 5.9.0,Cython==0.27.3andlxml==4.1.1).Related to #2213