Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Documentation #3089

Merged
merged 2 commits into from Jan 25, 2018
Merged

Changes in Documentation #3089

merged 2 commits into from Jan 25, 2018

Conversation

@yashrsharma44
Copy link
Contributor

@yashrsharma44 yashrsharma44 commented Jan 25, 2018

This is my first PR, so on going through the code, I found some typos, and corrected it.
Corrected Files: scrapy/utils/defer.py

This is my first PR, so on going through the code, I found some typos, and corrected it.
Changed some documentations
@kmike
Copy link
Member

@kmike kmike commented Jan 25, 2018

Looks good, thanks @yashrsharma44! Test failures are related to w3lib 1.19 release, not to your pull request.

@kmike kmike merged commit 1d15812 into scrapy:master Jan 25, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
kmike added a commit that referenced this pull request Jul 9, 2018
DOC typo fix in defer_fail docstring
@kmike kmike modified the milestones: v1.6, v1.5.1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.