Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to account for changes in w3lib 1.19 #3092

merged 1 commit into from Jan 26, 2018


Copy link

@kmike kmike commented Jan 25, 2018

Currently tests are failing because of behavior change introduced in scrapy/w3lib#101.

Copy link

@codecov codecov bot commented Jan 25, 2018

Codecov Report

Merging #3092 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3092   +/-   ##
  Coverage   84.55%   84.55%           
  Files         164      164           
  Lines        9291     9291           
  Branches     1381     1381           
  Hits         7856     7856           
  Misses       1177     1177           
  Partials      258      258
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/ 92.5% <0%> (ø) ⬆️
@dangra dangra merged commit 8be28fe into master Jan 26, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 786144e...ba15b63
continuous-integration/travis-ci/pr The Travis CI build passed
@dangra dangra deleted the fix-tests-for-w3lib-1.19 branch Jan 26, 2018
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@kmike kmike modified the milestones: v1.6, v1.5.1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants