Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix OS signal names #3096

Merged
merged 1 commit into from Feb 6, 2018
Merged

Conversation

@jesuslosada
Copy link
Contributor

@jesuslosada jesuslosada commented Jan 27, 2018

Using Ctrl-C to stop Scrapy when running it on Python 2 leads to this message:
Received SIGINT, shutting down gracefully. Send again to force

However, on some Python 3 versions (at least Python 3.5 and 3.6) Scrapy does not correctly detect the SIGINT signal:
Received SIG_SETMASK, shutting down gracefully. Send again to force

Some constants defined in the signal module need to be skipped in order to filter only the signals.
For reference:
https://github.com/python/cpython/blob/master/Lib/signal.py

@codecov
Copy link

@codecov codecov bot commented Jan 27, 2018

Codecov Report

Merging #3096 into master will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #3096   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         164      164           
  Lines        9291     9291           
  Branches     1381     1381           
=======================================
  Hits         7856     7856           
  Misses       1177     1177           
  Partials      258      258
Impacted Files Coverage Δ
scrapy/utils/ossignal.py 75% <66.66%> (ø) ⬆️

@kmike kmike changed the title Fix OS signal names [MRG+1] Fix OS signal names Jan 29, 2018
@kmike
Copy link
Member

@kmike kmike commented Jan 29, 2018

A good catch!

@lopuhin lopuhin merged commit fd02fa8 into scrapy:master Feb 6, 2018
1 of 2 checks passed
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@kmike kmike mentioned this pull request Jul 9, 2018
@kmike kmike removed this from the v1.6 milestone Jul 11, 2018
@kmike kmike added this to the v1.5.1 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants