Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] use INFO log level to show telnet host/port #3115

Merged
merged 1 commit into from Feb 8, 2018
Merged

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 8, 2018

Hey,

What do you think about using INFO log level for displaying telnet host/port information?

In production log level is often changed to INFO+. At the same time, a concrete telnet port is chosen from a range of ports. It means that log may be useless when someone wants to figure out how to connect to a running production spider, and Scrapy doesn't announce this port by other means.

I can also imagine that using INFO can raise awareness of users of this feature; some may want to disable it after realizing Scrapy is starting a telnet server by default, and some may do the opposite and start using the feature.

@codecov
Copy link

@codecov codecov bot commented Feb 8, 2018

Codecov Report

Merging #3115 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3115   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files         228      228           
  Lines        9577     9577           
  Branches     1382     1382           
=======================================
  Hits         7862     7862           
  Misses       1456     1456           
  Partials      259      259
Impacted Files Coverage Δ
scrapy/extensions/telnet.py 75% <100%> (ø) ⬆️
@lopuhin
Copy link
Member

@lopuhin lopuhin commented Feb 8, 2018

@kmike nice, I like the change 👍

@lopuhin lopuhin changed the title use INFO log level to show telnet host/port [MRG+1] use INFO log level to show telnet host/port Feb 8, 2018
@dangra dangra merged commit 68e45d3 into master Feb 8, 2018
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 82.09%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the telnet-log-level branch Feb 8, 2018
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants