Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contributing.rst #3127

Merged
merged 2 commits into from Feb 16, 2018
Merged

Updated contributing.rst #3127

merged 2 commits into from Feb 16, 2018

Conversation

@Anjalizi
Copy link
Contributor

@Anjalizi Anjalizi commented Feb 15, 2018

Rectified grammatical errors

Rectified grammatical errors
@@ -18,7 +18,7 @@ There are many ways to contribute to Scrapy. Here are some of them:
* Report bugs and request features in the `issue tracker`_, trying to follow
the guidelines detailed in `Reporting bugs`_ below.

* Submit patches for new functionality and/or bug fixes. Please read
* Submit patches for new functionalities and/or bug fixes. Please read

This comment has been minimized.

This comment has been minimized.

@cathalgarvey

cathalgarvey Feb 16, 2018
Contributor

Yea, either is fine I think. :)

@Anjalizi
Copy link
Contributor Author

@Anjalizi Anjalizi commented Feb 16, 2018

@codecov
Copy link

@codecov codecov bot commented Feb 16, 2018

Codecov Report

Merging #3127 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3127   +/-   ##
======================================
  Coverage    82.1%   82.1%           
======================================
  Files         228     228           
  Lines        9586    9586           
  Branches     1384    1384           
======================================
  Hits         7871    7871           
  Misses       1456    1456           
  Partials      259     259
@Anjalizi
Copy link
Contributor Author

@Anjalizi Anjalizi commented Feb 16, 2018

@kmike
Copy link
Member

@kmike kmike commented Feb 16, 2018

@Anjalizi yeah, I think other changes are good 👍 Let's summon @cathalgarvey :)

@@ -80,8 +80,8 @@ guidelines when reporting a new bug.
Writing patches
===============

The better written a patch is, the higher chance that it'll get accepted and
the sooner that will be merged.
The better written a patch is, higher is the chance that it'll get accepted and

This comment has been minimized.

@cathalgarvey

cathalgarvey Feb 16, 2018
Contributor

This line wasn't, and isn't, very idiomatic English. I would rephrase as "The better a patch is written, the higher the chances that it'll get accepted, and the sooner it will be merged".

@cathalgarvey
Copy link
Contributor

@cathalgarvey cathalgarvey commented Feb 16, 2018

Thanks @kmike and @Anjalizi - I left a comment on the last line, but the rest is great. :)

@Anjalizi
Copy link
Contributor Author

@Anjalizi Anjalizi commented Feb 16, 2018

@cathalgarvey
Copy link
Contributor

@cathalgarvey cathalgarvey commented Feb 16, 2018

Hey @Anjalizi - No need for a new PR, if you push new commits to the same branch on your repository (patch-2) then Github will automatically add them to this PR. :)

@cathalgarvey cathalgarvey merged commit 426da0e into scrapy:master Feb 16, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cathalgarvey
Copy link
Contributor

@cathalgarvey cathalgarvey commented Feb 16, 2018

Thank you @Anjalizi! :)

@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@kmike kmike modified the milestones: v1.6, v1.5.1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.