Updated contributing.rst

[Anjalizi]

Rectified grammatical errors

[kmike]

I'm not a native speaker, but https://english.stackexchange.com/questions/196590/functionality-vs-functionalities-are-both-correct-and-idiomatic seems to suggest "functionality" is ok here

[cathalgarvey]

Yea, either is fine I think. :)

[Anjalizi]

As per the english grammar guidelines, I suppose functionalities is fine but it's your take.

…

On 16-Feb-2018 8:15 PM, "Mikhail Korobov" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In docs/contributing.rst <#3127 (comment)>: > @@ -18,7 +18,7 @@ There are many ways to contribute to Scrapy. Here are some of them: * Report bugs and request features in the `issue tracker`_, trying to follow the guidelines detailed in `Reporting bugs`_ below. -* Submit patches for new functionality and/or bug fixes. Please read +* Submit patches for new functionalities and/or bug fixes. Please read I'm not a native speaker, but https://english.stackexchange. com/questions/196590/functionality-vs-functionalities-are-both- correct-and-idiomatic seems to suggest "functionality" is ok here — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3127 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZdZ0IEhkkuPXcx47HEOIYP234pNh480ks5tVZSMgaJpZM4SHQZt> .

[codecov]

Codecov Report

Merging #3127 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3127   +/-   ##
======================================
  Coverage    82.1%   82.1%           
======================================
  Files         228     228           
  Lines        9586    9586           
  Branches     1384    1384           
======================================
  Hits         7871    7871           
  Misses       1456    1456           
  Partials      259     259

[Anjalizi]

Also apart from "functionality" vs "functionalities" there was a significant grammatical error in the initial few lines.

…

On 16-Feb-2018 8:45 PM, "codecov[bot]" ***@***.***> wrote: Codecov <https://codecov.io/gh/scrapy/scrapy/pull/3127?src=pr&el=h1> Report Merging #3127 <https://codecov.io/gh/scrapy/scrapy/pull/3127?src=pr&el=desc> into master <https://codecov.io/gh/scrapy/scrapy/commit/f8c688e6f4704437085c706ae471c81a6dbaff4d?src=pr&el=desc> will *not change* coverage. The diff coverage is n/a. @@ Coverage Diff @@## master #3127 +/- ## ====================================== Coverage 82.1% 82.1% ====================================== Files 228 228 Lines 9586 9586 Branches 1384 1384 ====================================== Hits 7871 7871 Misses 1456 1456 Partials 259 259 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZdZ0OnwZxiuGUaqkwIQK088zaW0RDfgks5tVZuIgaJpZM4SHQZt> .

[kmike]

@Anjalizi yeah, I think other changes are good 👍 Let's summon @cathalgarvey :)

[cathalgarvey]

This line wasn't, and isn't, very idiomatic English. I would rephrase as "The better a patch is written, the higher the chances that it'll get accepted, and the sooner it will be merged".

[cathalgarvey]

Thanks @kmike and @Anjalizi - I left a comment on the last line, but the rest is great. :)

[Anjalizi]

It's fine sir. Should I edit and file a PR again?

…

On 16-Feb-2018 10:18 PM, "Cathal Garvey" ***@***.***> wrote: Thanks @kmike <https://github.com/kmike> and @Anjalizi <https://github.com/anjalizi> - I left a comment on the last line, but the rest is great. :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZdZ0Eu6UOCtAXI83bwhw7scJN_mcD7Nks5tVbFCgaJpZM4SHQZt> .

[cathalgarvey]

Hey @Anjalizi - No need for a new PR, if you push new commits to the same branch on your repository (patch-2) then Github will automatically add them to this PR. :)

[cathalgarvey]

Thank you @Anjalizi! :)